fix(material/core): sanity checks not running

[crisbeto]

Looks like when the granular sanity checks were introduced, some of the logic that determines whether a check should run wasn't written correctly which means that it isn't running at all.

These changes move the check logic into a separate method in order to make it less prone to mistakes.

[jelbourn]

So, to clarify, these checks were never running? If so, I'm not sure if turning them on now would be considered breaking- I might make this PR target: major.

[crisbeto]

Not never, but I think it regressed in #16973. These are all console.warn so they probably won't break people's builds. Also if they were failing, people's apps would look broken.

[jelbourn]

lgtm

[jelbourn]

Caretaker note: this might cause some Google teams to complain if they start seeing new warnings pop up in their logs

[eweap]

Hi,
Since this PR was merged, I see a warning for each of my unit test during tests run. It makes the output totally unusable unless I "hacked" the console.warn method, which is not a good idea.

I will stick to 12.2.0 until an acceptable solution is found.

[jelbourn]

@eweap these checks aren't supposed to run in test environments. Can you file an issue?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}