HLS variant playlist load errors are infinitely retried when AdsMediaSource is used

[TomVarga]

Version

Media3 main branch

More version details

last main SHA df8763ae0d295b16921a3eab312b98c0294a0b29

Devices that reproduce the issue

• Any device

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

These are the bare minimum changes that need to be made for the demo app:
a9b1468

Launch the demo app
Select the: Failing variant playlist HLS playlist example playlist

Expected result

Variant playlist errors are not infinitely retried

Actual result

Variant playlist errors are infinitely retried

Media

This is an HLS stream https://raw.githubusercontent.com/TomVarga/HLS-test-stream/refs/heads/main/10_mv_missing_variant_manifests/mv.m3u8 which has variant playlist that return 404

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

[TomVarga]

The following changes seem to solve the issue but I am not sure if this is the right approach:

4907fbd

[TomVarga]

Do please let me know if I am missing something and the variant playlist errors of the contentMediaSource when using AdsMediaSource should be handled some other way.

[tonihei]

Thanks for reporting! I'll send a fix for this issue. Your fix attempt is going in the right direction, but it seem the error suppression in MaskingMediaSource is not really needed and the issue can be reproduced without using AdsMediaSource.