[JetSnack] Move scroll state reads into layout phase via lambdas#778
Merged
bentrengrove merged 1 commit intomainfrom Apr 13, 2022
Merged
[JetSnack] Move scroll state reads into layout phase via lambdas#778bentrengrove merged 1 commit intomainfrom
bentrengrove merged 1 commit intomainfrom
Conversation
riggaroo
approved these changes
Apr 13, 2022
|
Your idea is so impressive for me. |
|
Great example for explaining this within my team. Thank you @bentrengrove ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes janky scrolling on the JetSnack details page.
Fixes #231
It should not be necessary to recompose just to relayout a page. JetSnack has a collapsing toolbar like layout on the details page, it shrinks the image and moves the title text up on scroll. This was previously done using composition but by moving the read of the scroll value into a lambda, we can read the value only during layout and skip the composition phase entirely.