Skip to content
This repository was archived by the owner on Nov 14, 2018. It is now read-only.

P final #582

Merged
JakeWharton merged 2 commits into from
Jul 16, 2018
Merged

P final #582

JakeWharton merged 2 commits into from
Jul 16, 2018

Conversation

@JakeWharton
Copy link
Contributor

@JakeWharton JakeWharton commented Jun 12, 2018

Closes #581

@tomaszrykala
Copy link

tomaszrykala commented Jun 12, 2018 •
edited
Loading

Won't this also require @RequiresApi(28) to be replaced with @TargetApi(28) in ImageDecoder.kt? It doesn't compile for me locally without it.

@JakeWharton
Copy link
Contributor Author

JakeWharton commented Jun 12, 2018

No. @TargetApi should never be used.

@gahfy gahfy mentioned this pull request Jul 8, 2018
Open
@JakeWharton JakeWharton merged commit 5100588 into master Jul 16, 2018
@JakeWharton JakeWharton deleted the p-final branch July 16, 2018 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chrisbanes chrisbanes chrisbanes approved these changes

@gahfy gahfy gahfy approved these changes

@thatfiredev thatfiredev thatfiredev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JakeWharton @tomaszrykala @chrisbanes @gahfy @thatfiredev