-
Notifications
You must be signed in to change notification settings - Fork 3
made resharper annotations internal #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok. I actually haven't changed the original code, I just built a
netstandard version for my own packages to reference. Sounds like your
change is reasonable enough, I'll have a look at it.
…On Mon, Jul 8, 2019 at 8:04 AM stylefish ***@***.***> wrote:
i've changed the visibility of the resharper annotations to "internal"
because when you use this library in your own project and don't want to use
the annotations, resharper automatically detects the ones from this library
and adds an import. i've looked how other libraries handle this and changed
the code of this annotations file accordingly :)
hope thats ok, if not feel free to comment and i try to change my PR as
suggested :)
greetings
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- made resharper annotations internal
File Changes
- *M* Inflector/JetBrainsAnnotations.cs
<https://github.com/andrewaggb/Inflector-NetStandard/pull/1/files#diff-0>
(136)
Patch Links:
- https://github.com/andrewaggb/Inflector-NetStandard/pull/1.patch
- https://github.com/andrewaggb/Inflector-NetStandard/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAMOF6Z4CZOQZM7ME6HWVT3P6NCNFA5CNFSM4H64B5E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G53SBAQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMOF6ZIBPDZNYRNCUUPGTDP6NCNFANCNFSM4H64B5EQ>
.
--
*Andrew Buchanan*
AB Integrations Inc
Email: andrew@ainvr.com
Ph: (780) 884-5197 <+17808845197>
|
|
anything new on this? :) |
|
@andrewaggb Could you please merge and release this? The public annotations cause so much confusion in our company code (we have our own copy of these annotations in a custom namespace, conforming to our standards) that I'm thinking about making my own fork, which would be really suboptimal. |
andrewaggb#1. Add MSDuration for edm.duration handling. #2. Change setters of Other date and time models
b05b442 to
6bc37ca
Compare
|
i forked this repository and set up an automatic build pipeline with publish to nuget.org: https://www.nuget.org/packages/Inflector.NetStd happy to accept PRs here https://github.com/stylefish/Inflector-NetStandard if theres anything missing anyway, thanks for your work to port this to NetStandard @andrewaggb ! :) |
i've changed the visibility of the resharper annotations to "internal" because when you use this library in your own project and don't want to use the annotations, resharper automatically detects the ones from this library and adds an import. i've looked how other libraries handle this and changed the code of this annotations file accordingly :)
hope thats ok, if not feel free to comment and i try to change my PR as suggested :)
greetings