Skip to content

Wdio Percy support v8 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amaanbs wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Wdio Percy support v8 #1

amaanbs wants to merge 44 commits into from

Conversation

@amaanbs
Copy link
Owner

@amaanbs amaanbs commented Dec 7, 2023

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

samarsault
samarsault reviewed Dec 8, 2023
View reviewed changes
samarsault
samarsault reviewed Dec 8, 2023
View reviewed changes
07souravkunda
07souravkunda requested changes Dec 12, 2023
View reviewed changes
packages/wdio-browserstack-service/src/types.ts
/**
* Set the Percy related config options under this key.
*/
percyOptions?: any;
Copy link
Collaborator

@07souravkunda 07souravkunda Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object

@07souravkunda
Copy link
Collaborator

07souravkunda commented Dec 12, 2023

add package-lock, npm ci breaking in tests.

07souravkunda
07souravkunda requested changes Dec 12, 2023
View reviewed changes
rev-doshi and others added 21 commits January 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@07souravkunda 07souravkunda 07souravkunda approved these changes

+1 more reviewer

@samarsault samarsault samarsault left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amaanbs @07souravkunda @samarsault @rev-doshi