Skip to content

Conversation

@AkshitaB
Copy link
Contributor

@AkshitaB AkshitaB commented Apr 15, 2022

NOTE: Absolute mess, do not attempt to review.

Fixes #270

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@AkshitaB AkshitaB marked this pull request as draft April 15, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move fairscale::with_wrapped_modules logic to a separate argument in the trainer

2 participants