Conversation
doiron
left a comment
There was a problem hiding this comment.
wow this is really great! My entire team here is very grateful for your time / efforts on getting this done!
thank you! thank you! thank you!
|
ignore the bad merge. fixing it. |
|
Do you want me to resolve the review comments you added? |
|
no I'm about done testing it right now. sorry about that was attempting to merge the package-lock.json file manually using the browser lol bad idea.. |
|
I fixed the conflicts and applied the changes based on your review. |
|
I just realized you created #458. |
|
thanks for fixing the conflict and updating, I got side tracked trying to fix some of the tests that are failing. I'm seeing functional test failures with these changes locally so currently trying to debug what is going on there. Once I can understand what needs to be done to fix them, I'll merge. update: oh one more thing, if you rebase now the integration tests should hopefully work. |
|
functional tests are failing, but I have a local fix for it, will push a PR after this bigger change is merged. |
Description of changes:
This change migrates aws-sdk support from v2 to v3. The former is going into maintenance mode sometimes this year. This will remove the below warning from being generated during the skill infrastructure deployment.
It includes some minor code refactoring and the removal of a duplicate test file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.