Skip to content

chore: migrate to aws-sdk v3#452

Merged
doiron merged 2 commits intoalexa:developfrom
jsetton:aws-sdk-v3
Apr 19, 2023
Merged

chore: migrate to aws-sdk v3#452
doiron merged 2 commits intoalexa:developfrom
jsetton:aws-sdk-v3

Conversation

@jsetton
Copy link
Contributor

@jsetton jsetton commented Apr 10, 2023

Description of changes:

This change migrates aws-sdk support from v2 to v3. The former is going into maintenance mode sometimes this year. This will remove the below warning from being generated during the skill infrastructure deployment.

==================== Deploy Skill Infrastructure ====================
(node:927) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)

It includes some minor code refactoring and the removal of a duplicate test file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jsetton jsetton changed the title Migrate to aws-sdk v3 chore: migrate to aws-sdk v3 Apr 10, 2023
Copy link
Contributor

@doiron doiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is really great! My entire team here is very grateful for your time / efforts on getting this done!

thank you! thank you! thank you!

@doiron
Copy link
Contributor

doiron commented Apr 18, 2023

ignore the bad merge. fixing it.

@jsetton
Copy link
Contributor Author

jsetton commented Apr 18, 2023

Do you want me to resolve the review comments you added?

@doiron
Copy link
Contributor

doiron commented Apr 18, 2023

no I'm about done testing it right now. sorry about that was attempting to merge the package-lock.json file manually using the browser lol bad idea..

@jsetton
Copy link
Contributor Author

jsetton commented Apr 18, 2023

I fixed the conflicts and applied the changes based on your review.

@jsetton
Copy link
Contributor Author

jsetton commented Apr 18, 2023

I just realized you created #458.

@doiron
Copy link
Contributor

doiron commented Apr 19, 2023

thanks for fixing the conflict and updating, I got side tracked trying to fix some of the tests that are failing. I'm seeing functional test failures with these changes locally so currently trying to debug what is going on there. Once I can understand what needs to be done to fix them, I'll merge.
thanks again this PR is a enormous help!

update: oh one more thing, if you rebase now the integration tests should hopefully work.

@doiron doiron merged commit fd96a52 into alexa:develop Apr 19, 2023
@doiron
Copy link
Contributor

doiron commented Apr 19, 2023

functional tests are failing, but I have a local fix for it, will push a PR after this bigger change is merged.

@jsetton jsetton deleted the aws-sdk-v3 branch April 19, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants