Add quaternion type support#15
Open
Narann wants to merge 1 commit intoalembic:masterfrom
Narann:quat-support
Open
Add quaternion type support#15Narann wants to merge 1 commit intoalembic:masterfrom Narann:quat-support
Narann wants to merge 1 commit intoalembic:masterfrom
Narann:quat-support
Conversation
Contributor
Author
|
Sorry for the forced push, I realize the interpretation check was missing: self.assertEqual(quatd.metadata["interpretation"], "quat") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
We needed to create Alembic from scratch having Quaternions but cask didn’t support Quaternions.
I’ve added the
Quattypes to cask and it works fine. I cleaned up modifications and added unit tests.Feel free to ask modifications.