fix: include workspace labels in the issue label dropdown in automation platform #139
Conversation
AdamSelene
left a comment
AdamSelene
left a comment
There was a problem hiding this comment.
Thanks ! Left a question and a suggestion
| for (const label of labels.nodes) { | ||
| // Prevent duplicates | ||
| if (!labelMap.has(label.id)) { | ||
| labelMap.set(label.id, label.name); | ||
| } | ||
| } |
There was a problem hiding this comment.
can the id be duplicated? That's weird 🤔
They don't use UUIDs? I would expect a workspace label ID to never collide with a team label ID
There was a problem hiding this comment.
I have updated the second api call to filter out the labels that are not associated with any team (as they will the global labels available in the workspace) and there is no longer a need to deduplicate a well, thank you!
| for (const label of labels.nodes) { | ||
| // Prevent duplicates | ||
| if (!labelMap.has(label.id)) { | ||
| labelMap.set(label.id, label.name); |
There was a problem hiding this comment.
Maybe add an indication that it's a workspace label?
E.g. [Workspace] prefix (or ideally something as explicit but more discreet 😄 )
There was a problem hiding this comment.
The labels are now in alphabetical order and the team labels are displayed first followed by the workspace labels.
For the grouping of the labels, I will contact activepieces if there is a way to do so, thank you!
AdamSelene
left a comment
AdamSelene
left a comment
There was a problem hiding this comment.
Thanks you can submit to ActivePieces!
meenulekha-premakumar
changed the title
AdamSelene
deleted the
meenu-lekhapremakumar/q-1756-linear-include-workspace-labels-in-dropdown
branch
2 participants
What does this PR do?
Currently in the automation platform, while team labels are available, workspace labels are not available fully. This PR includes workspace labels in the dropdown when creating linear tasks in the automation platform
Explain How the Feature Works
The API was only fetching team based labels initially due to the team filter in the API call
Updated the
labelsproperty inprops.tsto include workspace labels by removing this filterUsed a map to prevent duplicates in the labels
Relevant User Scenarios
Fixes # (issue)