Skip to content

Conversation

@tolik0
Copy link
Contributor

@tolik0 tolik0 commented Mar 19, 2024

What

Pin the airbyte-cdk version to ^0 to fix an error in acceptance tests related to the new validation of state messages:

    @staticmethod
    def _validate_state_messages(state_messages: List[AirbyteMessage], configured_catalog: ConfiguredAirbyteCatalog):
        # Ensure that at least one state message is emitted for each stream
>       assert len(state_messages) >= len(
            configured_catalog.streams
        ), "At least one state message should be emitted for each configured stream."
E       AssertionError: At least one state message should be emitted for each configured stream.

How

Sources that were successfully updated after increasing the CDK version include:

  • Airtable
  • Amazon Ads
  • Github
  • Google Ads
  • Google Analytics v4
  • Google Search Console
  • Iterable
  • Jira
  • Klaviyo
  • Linkedin Ads
  • Marketo
  • Mixpanel
  • Pinterest
  • Slack
  • Snapchat Marketing

Sources that required additional fixes:

  • Amazon Seller Partner - Fixed integration unit tests.
  • Bing Ads - Fixed integration unit tests.
  • Instagram - Fixed integration tests.
  • Source File - Resolved a minor conflict with the latest CDK version.

Other fixes include:

  • Google Sheets - Disabled a new test for state validation.
  • Twilio - Updated the expected records.

@vercel
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 9:54pm

Copy link
Contributor

@askarpets askarpets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🫵

@tolik0 tolik0 force-pushed the tolik0/source-connectors/fix-failed-state-tests branch from 39d0a44 to 1946e13 Compare March 20, 2024 20:32
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be incrementing connector versions using the minor number instead of patch because we are effectively releasing record counts for these connectors which is a feature add not a bug fix

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 20, 2024 20:52
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adjusting the minor versions instead of patch. I know it was probably tedious

@tolik0 tolik0 enabled auto-merge (squash) March 21, 2024 00:16
@tolik0 tolik0 merged commit df17c85 into master Mar 21, 2024
@tolik0 tolik0 deleted the tolik0/source-connectors/fix-failed-state-tests branch March 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment