Source Slack: Mark datefields in spec as dates #22889

arsenlosenko · 2023-02-13T10:29:19Z

What

Resolving:
#22777

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-13T10:29:43Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4162496563
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4162496563
🐛 https://gradle.com/s/gnulc5aow57uw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 1 skipped in 1604.87s (0:26:44) =============

arsenlosenko · 2023-02-21T11:20:23Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4232111551
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4232111551
🐛 https://gradle.com/s/m2kph44ezuxt2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 1 skipped in 2504.38s (0:41:44) =============

arsenlosenko · 2023-03-03T12:03:05Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4323207486

arsenlosenko · 2023-03-06T07:47:16Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4341088157
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4341088157
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_slack/__init__.py       2      0   100%
source_slack/source.py       225     19    92%
----------------------------------------------
TOTAL                        227     19    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 38 passed, 1 skipped in 3099.85s (0:51:39) ==================

arsenlosenko · 2023-04-03T08:31:16Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4594561408
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4594561408
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_slack/__init__.py       2      0   100%
source_slack/source.py       225     19    92%
----------------------------------------------
TOTAL                        227     19    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 5675.07s (1:34:35) ==================

arsenlosenko · 2023-04-03T18:26:03Z

/publish connector=connectors/source-slack

arsenlosenko · 2023-04-04T07:11:55Z

/publish connector=connectors/source-slack

🕑 Publishing the following connectors:
connectors/source-slack
https://github.com/airbytehq/airbyte/actions/runs/4605009487

Connector	Did it publish?	Were definitions generated?
connectors/source-slack	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Source Slack: Mark datefields in spec as dates

ef813f1

arsenlosenko self-assigned this Feb 13, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 13, 2023

arsenlosenko linked an issue Feb 13, 2023 that may be closed by this pull request

Source Slack: Mark datefields in properly as dates #22777

Closed

octavia-squidington-iii added the connectors/source/slack label Feb 13, 2023

arsenlosenko and others added 2 commits February 13, 2023 12:34

Update changelog

c857ad7

Merge branch 'master' into arsenlosenko/source-slack-format-date

d65be8f

Merge branch 'master' into arsenlosenko/source-slack-format-date

90f239c

Merge branch 'master' into arsenlosenko/source-slack-format-date

1d6b1f8

arsenlosenko added 3 commits April 3, 2023 10:12

Merge branch 'master' into arsenlosenko/source-slack-format-date

eebd49d

Update Dockerfile

ce7a80c

Merge branch 'master' into arsenlosenko/source-slack-format-date

474e832

arsenlosenko marked this pull request as ready for review April 3, 2023 11:20

arsenlosenko requested a review from lazebnyi April 3, 2023 11:20

lazebnyi approved these changes Apr 3, 2023

View reviewed changes

arsenlosenko added 2 commits April 3, 2023 18:38

Merge branch 'master' into arsenlosenko/source-slack-format-date

4fbe431

Merge branch 'master' into arsenlosenko/source-slack-format-date

41cbd3d

auto-bump connector version

31c1c8a

arsenlosenko merged commit ed1a740 into master Apr 4, 2023

arsenlosenko deleted the arsenlosenko/source-slack-format-date branch April 4, 2023 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Slack: Mark datefields in spec as dates #22889

Source Slack: Mark datefields in spec as dates #22889

Uh oh!

arsenlosenko commented Feb 13, 2023

Uh oh!

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

Uh oh!

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

Loading

Uh oh!

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

Uh oh!

arsenlosenko commented Mar 6, 2023 •

edited by github-actions bot

Loading

Uh oh!

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

Uh oh!

arsenlosenko commented Apr 3, 2023

Uh oh!

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Source Slack: Mark datefields in spec as dates #22889

Source Slack: Mark datefields in spec as dates #22889

Uh oh!

Conversation

arsenlosenko commented Feb 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Uh oh!

arsenlosenko commented Feb 13, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

Uh oh!

arsenlosenko commented Feb 21, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

Uh oh!

arsenlosenko commented Mar 3, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arsenlosenko commented Mar 6, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

arsenlosenko commented Apr 3, 2023

Uh oh!

arsenlosenko commented Apr 4, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 6, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

Loading