Fix off-by-one error in defining the start and end of an XYEnvironment#1303
Open
hal609 wants to merge 1 commit intoaimacode:masterfrom
Open
Fix off-by-one error in defining the start and end of an XYEnvironment#1303hal609 wants to merge 1 commit intoaimacode:masterfrom
hal609 wants to merge 1 commit intoaimacode:masterfrom
Conversation
weasdown
added a commit
to weasdown/aima-python
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new XYEnvironment object is created it is given attributes hight and width which are then used to assign the attributes x_end and y_end. However, the x_end and y_end should be one less than the width as the positional index starts at one.
By fixing this it ensures that the is_inbounds returns the correct value and environments can correctly check if things are inbounds.