Fix(llm-ollama): Set :reasoning to 'none does not take effect #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:reasoning Set to 'none' the request will ignore the thinking field, leading to the use of the default strategy
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
had a problem deploying
to
Continuous Integration
GitHub Actions
Failure
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
reviewed
Jan 21, 2026
… 'none' reasoning Correctly identify 'gpt-oss' models by using `llm-model-symbol`. Also ensure that when reasoning is set to 'none', it is correctly passed as `:false` in the request.
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
had a problem deploying
to
Continuous Integration
GitHub Actions
Failure
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
yydcnjjw
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
Owner
|
Thanks for your fix! I'm going to merge it in, but before I do that, I'd like to figure out why you can't run the tests successfully - probably an issue with my github secrets. So please wait for that, I should be able to get to it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:reasoning Set to 'none' the request will ignore the thinking field, leading to the use of the default strategy