feat: refactor and update proof types by atanmarko · Pull Request #87 · agglayer/provers

atanmarko · 2025-03-06T14:11:39Z

Description

Update proof types to match latest proto changes.

Fixes #86

PR Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added or updated tests that comprehensively prove my change is effective or that my feature works

iljakuklic

Looks good to me code-wise. However, I am missing some context regarding the motivation for these changes.

crates/prover-alloy/Cargo.toml

crates/aggchain-proof-types/src/proof.rs

crates/aggchain-proof-builder/Cargo.toml

crates/aggchain-proof-types/src/proof.rs

crates/aggchain-proof-service/src/service.rs

crates/aggkit-prover/src/rpc.rs

crates/proposer-client/Cargo.toml

crates/aggchain-proof-types/src/lib.rs

crates/aggkit-prover/src/tests/mod.rs

crates/proposer-client/src/rpc.rs

crates/proposer-service/src/lib.rs

crates/prover-alloy/src/lib.rs

atanmarko · 2025-03-10T11:48:03Z

Note: put to draft to rebase on top of #84

crates/aggchain-proof-types/Cargo.toml

crates/aggkit-prover-types/src/error.rs

crates/aggkit-prover-types/src/conversion.rs

crates/aggchain-proof-types/src/proof.rs

crates/aggkit-prover-types/src/error.rs

PR significantly changed

crates/aggkit-prover-types/src/error.rs

Ekleog-Polygon

LGTM! There's just the hex encoding issue that I think will cause trouble if landed as-is.

(Sorry, I forgot to click the "submit review" yesterday, and just noticed by chance…)

crates/aggchain-proof-types/Cargo.toml

crates/aggkit-prover-types/src/conversion.rs

crates/prover-alloy/src/lib.rs

Digest error type changed

crates/aggkit-prover-types/src/error.rs

crates/aggkit-prover-types/Cargo.toml

Ekleog-Polygon

LGTM! :)

atanmarko added the agglayer/provers label Mar 6, 2025

atanmarko added this to the v0.3.0-provers milestone Mar 6, 2025

atanmarko self-assigned this Mar 6, 2025

atanmarko force-pushed the feat/update-proof-types branch from dc3368c to 01ca498 Compare March 6, 2025 15:04

atanmarko marked this pull request as ready for review March 6, 2025 15:04

atanmarko requested a review from a team as a code owner March 6, 2025 15:04

atanmarko requested review from Ekleog-Polygon, Freyskeyd, hadjiszs and iljakuklic March 6, 2025 15:04

iljakuklic reviewed Mar 6, 2025

View reviewed changes

crates/prover-alloy/Cargo.toml Show resolved Hide resolved

crates/aggchain-proof-types/src/proof.rs Show resolved Hide resolved

Freyskeyd previously requested changes Mar 7, 2025

View reviewed changes

Freyskeyd reviewed Mar 7, 2025

View reviewed changes

crates/prover-alloy/src/lib.rs Outdated Show resolved Hide resolved

crates/prover-alloy/src/lib.rs Outdated Show resolved Hide resolved

atanmarko requested review from Freyskeyd and iljakuklic March 7, 2025 09:12

This was referenced Mar 7, 2025

Re-enable the tests already present in the aggkit-prover crate #74

Open

Implement AggchainProofBuilder tests #88

Open

atanmarko marked this pull request as draft March 10, 2025 11:47

atanmarko force-pushed the feat/update-proof-types branch from 357c80b to be9a358 Compare March 10, 2025 17:07

atanmarko changed the base branch from main to bridge-proof-remaining March 10, 2025 17:07

Base automatically changed from bridge-proof-remaining to main March 12, 2025 18:34

atanmarko force-pushed the feat/update-proof-types branch from be9a358 to 156f8b2 Compare March 12, 2025 19:21

atanmarko marked this pull request as ready for review March 12, 2025 19:22

feat: refactor and update types

6c52114

atanmarko closed this Mar 13, 2025

atanmarko force-pushed the feat/update-proof-types branch from 156f8b2 to ab22c83 Compare March 13, 2025 11:08

atanmarko reopened this Mar 13, 2025

fix: remove network index

2ab698c

hadjiszs previously approved these changes Mar 13, 2025

View reviewed changes

crates/aggchain-proof-types/Cargo.toml Outdated Show resolved Hide resolved

crates/aggkit-prover-types/src/error.rs Outdated Show resolved Hide resolved

crates/aggkit-prover-types/src/conversion.rs Outdated Show resolved Hide resolved

fix: review cleanup

94208e8

atanmarko dismissed hadjiszs’s stale review via 94208e8 March 13, 2025 13:23

atanmarko and others added 3 commits March 13, 2025 14:23

Merge branch 'main' into feat/update-proof-types

4febdb7

Merge remote-tracking branch 'origin/main' into HEAD

e34cf0c

fix: tests

d5232bc

atanmarko requested a review from hadjiszs March 13, 2025 15:21

iljakuklic reviewed Mar 13, 2025

View reviewed changes

crates/aggchain-proof-types/src/proof.rs Outdated Show resolved Hide resolved

crates/aggchain-proof-types/src/proof.rs Show resolved Hide resolved

crates/aggkit-prover-types/src/error.rs Outdated Show resolved Hide resolved

fix: review

4f18b33

atanmarko requested a review from iljakuklic March 13, 2025 17:52

Merge branch 'main' into feat/update-proof-types

ee62f88

iljakuklic previously approved these changes Mar 13, 2025

View reviewed changes

crates/aggkit-prover-types/src/error.rs Outdated Show resolved Hide resolved

Ekleog-Polygon previously requested changes Mar 14, 2025

View reviewed changes

crates/aggchain-proof-types/Cargo.toml Show resolved Hide resolved

crates/aggkit-prover-types/src/conversion.rs Show resolved Hide resolved

crates/prover-alloy/src/lib.rs Outdated Show resolved Hide resolved

fix: return value

14cf5a6

atanmarko dismissed iljakuklic’s stale review via 14cf5a6 March 14, 2025 08:17

atanmarko requested a review from Ekleog-Polygon March 14, 2025 08:33

atanmarko force-pushed the feat/update-proof-types branch from 6a4f0e8 to be650fa Compare March 14, 2025 08:35

Ekleog-Polygon reviewed Mar 14, 2025

View reviewed changes

crates/aggkit-prover-types/src/error.rs Outdated Show resolved Hide resolved

crates/aggkit-prover-types/Cargo.toml Outdated Show resolved Hide resolved

fix: change digest error type

e293ef4

atanmarko force-pushed the feat/update-proof-types branch from be650fa to e293ef4 Compare March 14, 2025 08:38

Marko Atanasievski added 2 commits March 14, 2025 09:41

fix: remove hex dependency

c99f675

fix: rename error

2c273cc

atanmarko requested review from Ekleog-Polygon and iljakuklic March 14, 2025 08:43

fix: format

4260a7a

Ekleog-Polygon approved these changes Mar 14, 2025

View reviewed changes

atanmarko merged commit e6a6dc9 into main Mar 14, 2025
12 checks passed

Conversation

atanmarko commented Mar 6, 2025

Description

PR Checklist:

Uh oh!

iljakuklic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atanmarko commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ekleog-Polygon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ekleog-Polygon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments