Draft
Conversation
jhkimqd
approved these changes
Aug 27, 2025
Comment on lines
+53
to
+57
| # 2025-08-27: I'm not sure if these are necessary. Delete entirely if this doesn't break anything | ||
| # permissions: | ||
| # contents: read | ||
| # packages: write | ||
| # id-token: write |
Contributor
There was a problem hiding this comment.
I might be wrong, but in the past removing this caused sonarqube or some other security warnings
Collaborator
There was a problem hiding this comment.
not sonarqube but it won't be able to pull images from the the google cloud registry - we might need to document
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jhilliard/else-case
branch
from
89bc4d1 to
152bd71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.