Skip to content

Conversation

@moorereason
Copy link
Collaborator

To avoid having to pass around so many parameters to the hook package,
create a Request object to store all request-specific data. Update APIs
accordingly.

To avoid having to pass around so many parameters to the hook package,
create a Request object to store all request-specific data.  Update APIs
accordingly.
@moorereason
Copy link
Collaborator Author

@adnanh,
I'm submitting this PR as a proposal since it will likely create a bunch of merge conflicts for your context branch. Although, if I had done this earlier, you could have simply added a Context to the Request and not had to update so many function signatures. If you want to wait on this until your context work is complete, I'm okay with that.

There's no functional change to the user. This is simply a simplification of the internal hook API.

Let me know what you think.

@adnanh
Copy link
Owner

adnanh commented Sep 26, 2020

Perfect, merging right away :-)

@adnanh adnanh merged commit 6797bf7 into adnanh:development Sep 26, 2020
@moorereason moorereason deleted the req-context branch September 26, 2020 15:25
@moorereason moorereason added this to the 2.8.0 milestone Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants