Vendor code using godep. #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activating Open Collective
For 3rd parties building binary packages, and for build consistency in general, it is very helpful to have the same set of dependencies at any time the product is built. See [tools/godep](https://github.com/tools/godep) for further details.
Contributor
Author
|
I did manage to work around the non-vendored dependencies by using a trick the Ports system in FreeBSD uses, but it's ugly, and likely to break easily. The FreeBSD change is here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222883 |
Owner
|
Thanks for the contribution! |
Owner
|
It's live on master & 2.6.6 Figured you'd like to be notified :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 3rd parties building binary packages, and for build consistency in
general, it is very helpful to have the same set of dependencies at
any time the product is built.
See tools/godep for further details.
Specifically, I'm working on creating a FreeBSD Port (see https://www.freebsd.org/ports/), and the FreeBSD Go build environment requires a Go project to either supply all dependencies in
vendor/, or have them installed as FreeBSD Ports themselves. The latter does get unwieldy quickly, so I'd appreciate the vendoring a lot!