Static parameter warning #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md for Debian stretch release of webhook package
…specified erroneously
gdubicki
reviewed
Aug 27, 2017
| log.Printf("unable to locate command: '%s'", h.ExecuteCommand) | ||
|
|
||
| // check if parameters specified in execute-command by mistake | ||
| if strings.IndexByte(h.ExecuteCommand, ' ') != -1 { |
Contributor
There was a problem hiding this comment.
This way of checking it will log a false alarm for binaries with spaces in their names.
Owner
|
Looks great! If you could add some tests for this feature, I would be more than glad to merge it in! Thanks. |
Contributor
Author
|
@adnanh I've added tests for this feature -- let me know if they look fine. Thanks. |
|
It's not documented anywhere how to use "pass-arguments-to-command" |
Collaborator
|
@simplenotezy, To answer your question, see the Github example at https://github.com/adnanh/webhook/blob/master/docs/Hook-Examples.md#incoming-github-webhook |
Repository owner
locked as resolved and limited conversation to collaborators
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the logic to produce log warning if static command line parameters are specified in 'execute-command' (issue #151):
"execute-command": "/bin/echo test"will produce:
Let me know if you want me to do it in a different way.