Skip to content

🚨 [security] Update @actions/http-client: 1.0.6 β†’ 1.0.9 (patch)#6

Open
depfu[bot] wants to merge 1 commit intomainfrom
depfu/update/npm/@actions/http-client-1.0.9
Open

🚨 [security] Update @actions/http-client: 1.0.6 β†’ 1.0.9 (patch)#6
depfu[bot] wants to merge 1 commit intomainfrom
depfu/update/npm/@actions/http-client-1.0.9

Conversation

@depfu
Copy link

@depfu depfu bot commented Nov 20, 2020


Welcome to Depfu πŸ‘‹

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!



🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @​actions/http-client (1.0.6 β†’ 1.0.9) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 Http request which redirect to another hostname do not strip authorization header in @actions/http-client

Impact

If consumers of the http-client:

  1. make an http request with an authorization header
  2. that request leads to a redirect (302) and
  3. the redirect url redirects to another domain or hostname

The authorization header will get passed to the other domain.

Note that since this library is for actions, the GITHUB_TOKEN that is available in actions is generated and scoped per job with these permissions.

Patches

The problem is fixed in 1.0.8 at npm here. In 1.0.8, the authorization header is stripped before making the redirected request if the hostname is different.

Workarounds

None.

References

#27

For more information

If you have any questions or comments about this advisory:

Release Notes

1.0.7 (from changelog)

Update NPM dependencies and add 429 to the list of HttpCodes

Does any of this look wrong? Please let us know.


πŸ‘‰ No CI detected

You don't seem to have any Continuous Integration service set up!

Without a service that will test the Depfu branches and pull requests, we can't inform you if incoming updates actually work with your app. We think that this degrades the service we're trying to provide down to a point where it is more or less meaningless.

This is fine if you just want to give Depfu a quick try. If you want to really let Depfu help you keep your app up-to-date, we recommend setting up a CI system:

  • Circle CI, Semaphore and Travis-CI are all excellent options.
  • If you use something like Jenkins, make sure that you're using the Github integration correctly so that it reports status data back to Github.
  • If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with depfu/.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Nov 20, 2020
@changelogg
Copy link

changelogg bot commented Nov 20, 2020

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@performance-testing-bot
Copy link

Unable to locate .performanceTestingBot config file

@spampr
Copy link

spampr bot commented Nov 20, 2020

This pull request seems genuine

@scribe-connect
Copy link

Linked documents: 0
Files with no linked documents: 2
Recently updated documents: 0
Out of date documents: 0
Very out of date documents: 0

@commit-lint
Copy link

commit-lint bot commented Nov 20, 2020

Contributors

@depfu[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@depchecker-bot
Copy link

1 updated dependency for you to review.

@actions/http-client - Actions Http Client
NPM | GitHub Repo | Homepage
Latest Version: 1.0.9 | Project Version: ^1.0.6 -> ^1.0.9

  • Last publish was a month ago
  • 168,368 weekly downloads
  • 39 stars on Github
  • MIT License
  • 11 open issues and pull requests

@trafico-bot trafico-bot bot added the πŸ” Ready for Review Pull Request is not reviewed yet label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants