-
Notifications
You must be signed in to change notification settings - Fork 320
ATK-4335: add delay detector #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDelayDetector.java
Fixed
Show fixed
Hide fixed
src/main/java/com/actiontech/dble/backend/heartbeat/MySQLShowSlaveStatusDetector.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/actiontech/dble/backend/heartbeat/MySQLShowSlaveStatusDetector.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/actiontech/dble/config/loader/xml/XMLDbLoader.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/actiontech/dble/services/manager/information/tables/DbleDelayDetection.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/actiontech/dble/services/manager/information/tables/DbleDelayDetection.java
Dismissed
Show dismissed
Hide dismissed
dcy10000
reviewed
Mar 21, 2025
src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDefaultDetector.java
Show resolved
Hide resolved
src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDelayDetector.java
Dismissed
Show dismissed
Hide dismissed
Member
Author
|
已测完 |
dcy10000
reviewed
Mar 24, 2025
src/main/java/com/actiontech/dble/backend/datasource/PhysicalDbInstance.java
Show resolved
Hide resolved
src/main/java/com/actiontech/dble/config/ConfigInitializer.java
Outdated
Show resolved
Hide resolved
dcy10000
approved these changes
Mar 24, 2025
Member
dcy10000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
Improve #.
Type:
Improve
Influences:
沿用了心跳的处理逻辑和原先show slave status的逻辑,只不过 salve_behind_master 的计算逻辑有所区别,这样开发/测试成本最低。