Skip to content

Filter comments by content instead of actor #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luketomlinson merged 4 commits into from
Jul 12, 2021
Merged

Filter comments by content instead of actor #519

luketomlinson merged 4 commits into from
Jul 12, 2021

Conversation

@luketomlinson
Copy link
Collaborator

@luketomlinson luketomlinson commented Jul 1, 2021

Changes

Fixes #509
Fixes #441
Fixes #518

@luketomlinson luketomlinson requested a review from a team as a code owner July 1, 2021 21:06
C0ZEN
C0ZEN approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@C0ZEN C0ZEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good

C0ZEN
C0ZEN reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@C0ZEN C0ZEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this line should be updated?

stale/README.md

Line 312 in 678bfc7

Only the [actor](#repo-token) and the batch of issues (100 per batch) will consume the operations.

@luketomlinson luketomlinson merged commit d901397 into main Jul 12, 2021
@luketomlinson luketomlinson deleted the bugfix/518-comment-filtering branch July 12, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@C0ZEN C0ZEN C0ZEN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't filter comments by actor stale label not removed from issue that had an update Stale label not being removed after new activity

3 participants

@luketomlinson @C0ZEN