Merged
Conversation
ericsciple
commented
Feb 13, 2020
ericsciple
commented
Feb 13, 2020
ericsciple
commented
Feb 13, 2020
|
Does this proposal mean that we can also do Now, the GitHub Pages Actions provides the SSH key input option to avoid the problem. It is useful that the setting up SSH key is supported by actions/checkout. Thank you. |
ericsciple
commented
Feb 18, 2020
Contributor
Author
|
@peaceiris yes the ssh key will be persisted so you can script authenticated git commands. Will be removed at the end of the job. |
chrispat
approved these changes
Feb 19, 2020
8d97a3b to
2db4320
Compare
Contributor
Author
|
reviewed offline w/ @thechrisjohnson |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing adding SSH support. This will help for users scripting submodule checkout.
Will open a separate ADR for a first-class
submoduleinput.