Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Add volume toggle#47

Merged
jonpas merged 14 commits intoacemod:masterfrom
jameslkingsley:volume
Feb 25, 2017
Merged

Add volume toggle#47
jonpas merged 14 commits intoacemod:masterfrom
jameslkingsley:volume

Conversation

@jameslkingsley
Copy link
Contributor

@jameslkingsley jameslkingsley commented Nov 9, 2016

When merged this pull request will:

  • Add a keybind to toggle volume of game and music
  • Allows you to change the reduction percentage via ACE settings

Essentially the same functionality as the Cyprus Push-to-Hear mod. It's quite useful for when you're briefing in heavy rain, or if you're in an obnoxiously loud car.

Features:

  • Automatically lower volume when inside vehicles (restores when exiting vehicles)
  • Change reduction percentage and fade delay
  • Option to show/hide notification
  • Option to remind you every minute if your volume is lowered

@jonpas jonpas added this to the 3.2.0 milestone Nov 9, 2016
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I had those comments prepared but never submitted the review. O.o


// #define DEBUG_MODE_FULL
// #define DISABLE_COMPILE_CACHE
// #define CBA_DEBUG_SYNCHRONOUS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used, remove.

<English>Reduction</English>
</Key>
<Key ID="STR_ACEX_Volume_ReductionDescription">
<English>Reduce volume by this percentage</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final dot.

<English>Toggle Volume</English>
</Key>
<Key ID="STR_ACEX_Volume_KeybindDescription">
<English>Toggle volume reduction</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final dot.

@jonpas jonpas merged commit f73b503 into acemod:master Feb 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants