Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Killtracker - Add localized entries#231

Merged
PabstMirror merged 7 commits intoacemod:masterfrom
severgun:localizeKilltracker
Jun 20, 2020
Merged

Killtracker - Add localized entries#231
PabstMirror merged 7 commits intoacemod:masterfrom
severgun:localizeKilltracker

Conversation

@severgun
Copy link
Contributor

When merged this pull request will:

  • Title
  • Add Russian translation

GVAR(killCount) = GVAR(killCount) + 1;
GVAR(eventsArray) pushBack format ["Killed: %1 %2", _name, _killInfo];
GVAR(outputText) = (format ["Total Kills: %1<br/>", GVAR(killCount)]) + (GVAR(eventsArray) joinString "<br/>");
GVAR(eventsArray) pushBack format [LLSTRING(Killed), _name, _killInfo];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like <br/> should be non-localized here and below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, looks like there too

private _killerSide = [_killer] call _fnc_getSideFromConfig;
if ([_unitSide, _killerSide] call BIS_fnc_areFriendly) then {
_killInfo pushBack "<t color='#ff0000'>Friendly Fire</t>";
_killInfo pushBack LLSTRING(FriendlyFire);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for <t color='#ff0000'> and </t>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        <Key ID="str_a3_cfgvehicles_modulefriendlyfire_f_0">
          <Original>Friendly Fire</Original>
          <Chinese>誤擊友方</Chinese>
          <French>Tir fratricide</French>
          <Spanish>Fuego aliado</Spanish>
          <Italian>Fuoco amico</Italian>
          <Polish>Ostrzał sojuszniczy</Polish>
          <Russian>Дружественный огонь</Russian>
          <German>Teambeschuss</German>
          <Czech>Střelba do vlastních!</Czech>
          <English>Friendly Fire</English>
          <Portuguese>Fogo amigo</Portuguese>
          <Korean>아군 오인사격</Korean>
          <Chinesesimp>友军误射</Chinesesimp>
          <Japanese>同士討ち</Japanese>
          <Turkish>Dost Atışı</Turkish>
        </Key>

Copy link
Contributor Author

@severgun severgun Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So? Should I remove tags or keep it consistent to other stringtables? Should I copy paste translations for FriendlyFire or use this ID?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late reply, this is fine as people can change if the BIS wording isn't right

</Key>
<Key ID="STR_ACEX_KillTracker_Died">
<Original>Died: %1 %2</Original>
<Russian>Убийца: %1 %2</Russian>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

довольно странный перевод для Died. Может лучше Умер или Погиб?

Copy link
Contributor Author

@severgun severgun Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В статистике это именно тот кто убил тебя. Поэтому тут вопросы к оригиналу Died -> Killer
Я думаю это из-за того что в английском языке различие в 1 букве вносит неразбериху.

</Key>
<Key ID="STR_ACEX_KillTracker_FriendlyFire">
<Original>&lt;t color='#ff0000'&gt;Friendly Fire&lt;/t&gt;</Original>
<Russian>&lt;t color='#ff0000'&gt;Союзник&lt;/t&gt;</Russian>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы сказал Свой (огонь по своим)

@PabstMirror PabstMirror added this to the 3.6.0 milestone Apr 21, 2020
@PabstMirror PabstMirror merged commit 42b31a5 into acemod:master Jun 20, 2020
@PabstMirror PabstMirror changed the title Add localized entries for acex_killtracker Killtracker - Add localized entries Jun 20, 2020
@severgun severgun deleted the localizeKilltracker branch June 21, 2020 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants