Multi Player Sitting (rework #122)

[jonpas]

When merged this pull request will:

• Add everything in Multi Player Sitting #122 in a better, more integrated way
• Add Arm Chair and fix inheritance on benches
• Improve variable naming

[jokoho48]

why not use the inverse of that and check for isEqualType Number?

[jonpas]

I could, doesn't make a difference here though.

[Dystopian]

Suggested change

	{(_seat getVariable [QGVAR(seatsClaimed), []]) find true == -1} &&
	{
	private _seatsClaimed = _seat getVariable [QGVAR(seatsClaimed), []];
	_seatsClaimed isEqualTo []
	|| {_seatsClaimed find false > -1}
	} &&

I didn't test your code neither mine (will try later this day), but looks like your condition is false when any seat is claimed, so only one person would be able to multi-seat.

[jonpas]

Good point, I should just be checking that specific index (seat pos) or empty!

[jonpas]

@Dystopian if you can give it a test that'd be great. I tested in editor with 2 units.

[Dystopian]

cursorObject instead of seat in all functions examples would be much more useful

[jonpas]

It's an object, that's all that matters, you can get it in thousands of different ways. :)

[Dystopian]

I meant for copy-paste, just paste to debug console and hit EXEC

[PabstMirror]

having code example you can use instantly is always nice

[jonpas]

Good point, I am always too lazy with copy/pasting. 😆

[Dystopian]

tested, works perfectly (SP)

[PabstMirror]

[jonpas]

@PabstMirror how? MP or SP? Which bench?

[Dystopian]

@jonpas It's easily done with acex_sitting_fnc_sit call on AI in debug console and I suppose it can be done in MP when some players try to seat to the same seat simultaneously.

I think it's enough to just add FUNC(canSit) check to fnc_sit.

[Dystopian]

_seatPos argument should be documented in header.

[jonpas]

Oh but for AI I won't add special checks, it's up to whoever calls it to also call canSeat. Or not, people find interesting use cases. :D

[jonpas]

I suppose it can be done in MP when some players try to seat to the same seat simultaneously.

Almost missed that, that's probably a good reason to add it.

[PabstMirror]

Land_bench_01_f, 2 players (non-dedicated)
the sit action is inside the first sitting player, so it's hard to see, but still possible if close enough

[PabstMirror]

seatPos array was only getting set to true on first run if (_seatsClaimed isEqualTo []) then {
seems to work fine now

[jonpas]

Wow, I should not work on this stuff at 3am... I now remember thinking I have to add normal handling and not just first run. :D

Thanks @PabstMirror !