This repository was archived by the owner on May 24, 2022. It is now read-only.
Fortify - Improve deploy handlers check#131
Merged
PabstMirror merged 3 commits intoacemod:masterfrom Aug 1, 2018
Merged
Conversation
dedmen
reviewed
Jul 12, 2018
| GVAR(isPlacing) = PLACE_WAITING; | ||
| }; | ||
| { | ||
| if !([_unit, _object, _cost] call _x) exitWith { |
Contributor
There was a problem hiding this comment.
could use findIf instead.
if findIf {code} != -1 -> GVAR(isPlacing....
dedmen
approved these changes
Jul 12, 2018
PabstMirror
reviewed
Jul 20, 2018
| GVAR(isPlacing) = PLACE_WAITING; | ||
| }; | ||
| // If place approved, verify deploy handlers | ||
| if (GVAR(isPlacing) == PLACE_APPROVE && {GVAR(deployHandlers) findIf {!([_unit, _object, _cost] call _x)} > -1}) then { |
Contributor
There was a problem hiding this comment.
Slightly more robust way might be to use isEqualTo, but it's probably not needed
x0 = [{true}, {nil}, {5}, {false}];
x1 = x0 findIf {!(call _x)}; // nil
x2 = x0 findIf {false isEqualTo call _x} // 3
PabstMirror
approved these changes
Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
{true}inaddDeployHandlerfunction