Skip to content

Conversation

@craff
Copy link

@craff craff commented Jun 30, 2023

Solves issue #70

@craff
Copy link
Author

craff commented Jun 30, 2023

I tried to fix/update the github workflow. I think it is now OK (not sure),
but there are some opam download that fails, even after I added opam update !

@craff craff mentioned this pull request Jul 4, 2023
Copy link
Owner

@aantron aantron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few nits, all of which I can apply myself -- please let me know!

@craff
Copy link
Author

craff commented Jul 17, 2023

Am I supposed to do something for the coverage ?

@aantron
Copy link
Owner

aantron commented Jul 17, 2023

Am I supposed to do something for the coverage ?

Not necessary, unless you'd like to write some nice test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants