Skip to content

🎨 Palette: Remove hardcoded text color on Camera Fragment Switches#69

Open
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-switch-text-color-3435499740452840649
Open

🎨 Palette: Remove hardcoded text color on Camera Fragment Switches#69
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-switch-text-color-3435499740452840649

Conversation

@manupawickramasinghe
Copy link
Copy Markdown
Member

💡 What: Removed hardcoded android:textColor="#C1C1C1" from the three switch elements (switch1, switch2, switchRTSP) in fragment_camera.xml.
🎯 Why: Hardcoding light grey text causes severe contrast and readability issues if the app is used on a lighter background or if the user switches system themes. By removing the hardcoded value, the Switch text automatically inherits the color defined by @style/TextAppearance.AppCompat.Medium and the global AppTheme.
📸 Before/After: Before, switch text was always a faded grey. After, it conforms to proper text styling provided by the app's theme attributes.
♿ Accessibility: Ensures that interactive switch components consistently meet text contrast ratios regardless of device mode settings, significantly improving readability.


PR created automatically by Jules for task 3435499740452840649 started by @manupawickramasinghe

This commit removes `android:textColor="#C1C1C1"` from the preview, stream, and RTSP switches in `fragment_camera.xml`. The switches now correctly inherit their text color from `TextAppearance.AppCompat.Medium`, fixing contrast and accessibility issues that could occur on light themes or when system modes change.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant