Support authenticatorAttachment in PublicKeyCredential#250
Merged
emlun merged 4 commits intoYubico:mainfrom Dec 16, 2022
Merged
Conversation
Contributor
Author
|
Failing at |
Member
|
Thanks but no need, I've already pushed a fix. 🙂 |
emlun
approved these changes
Dec 16, 2022
Member
emlun
left a comment
emlun
left a comment
There was a problem hiding this comment.
This looks really good, thanks!
Would you like to be credited in the release notes? And if so, by GitHub username or real name?
Contributor
Author
|
Thanks for the help, and for the library. Sure, why not :) use the GH username. |
luisgoncalves
deleted the
feature/credential-authenticator-attachment
branch
emlun
added a commit
that referenced
this pull request
Jan 11, 2023
New features:
- (Experimental) Added `authenticatorAttachment` property to response
objects:
- NOTE: Experimental features may receive breaking changes without a
major version increase.
- Added method `getAuthenticatorAttachment()` to
`PublicKeyCredential` and corresponding builder method
`authenticatorAttachment(AuthenticatorAttachment)`.
- Added method `getAuthenticatorAttachment()` to
`RegistrationResult` and `AssertionResult`, which echo
`getAuthenticatorAttachment()` from the corresponding
`PublicKeyCredential`.
- Thanks to GitHub user luisgoncalves for the contribution, see
#250
Other:
- Fixed the README description of SemVer exceptions: `@Deprecated`
features are still part of the public API unless they also have an
`EXPERIMENTAL:` tag in JavaDoc.
- Brought `com.yubico.webauthn` package JavaDoc up to date with new
library features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249.