FLINK-5911: Orchestrator cleanup in status.py (PR 4/4)

[nleigh]

Ticket: https://jira.yelpcorp.com/browse/FLINK-5911

Part 4 of 4. Final cleanup — all Flink logic now lives in `flink_tools.py`; `status.py` is a thin orchestrator.

Also addresses feedback from PR 3 (#4285):

• `checkpoint_data` typed as `Dict[str, Union[FlinkCheckpointStatus, BaseException]]` (was `Dict[str, Any]`) in both `format_flink_jobs_table` and the call site in `status.py`
• `_fetch_flink_job_details` / `fetch_flink_job_checkpoints` renamed to drop the `` prefix — they are called cross-module so the private prefix was misleading
• `should_job_info_be_shown` uses a set literal instead of a tuple
• `format_flink_jobs_table` signature simplified: `job_ids` removed (was never used inside the function; job IDs are accessed via `job["jid"]`), `checkpoint_data` made an optional keyword arg defaulting to `None`
• `TestFormatFlinkJobsTable` test class added: verbose job ID display, 3-job non-verbose limit, verbose shows all jobs, failed state color, checkpoint/restart display, `None` dashboard URL guard

Changes

`paasta_tools/flink_tools.py`

• `format_flink_jobs_table` signature: `(jobs, dashboard_url, verbose, checkpoint_data=None)`
• `fetch_flink_job_details` / `fetch_flink_job_checkpoints`: public names (no `_` prefix)
• `should_job_info_be_shown`: set literal
• `checkpoint_data` typed as `Dict[str, Union[FlinkCheckpointStatus, BaseException]]`

`paasta_tools/cli/cmds/status.py`

• Removed direct imports of `get_flink_config/overview/jobs_from_paasta_api_client` — now called as `flink_tools.*`
• Removed `FlinkJobs` import and `FlinkJobs()` fallback; `jobs`/`job_ids`/`overview`/`checkpoint_data` initialized upfront
• All API fetches (config, overview, jobs, checkpoints) consolidated into a single `if state == "running":` block
• `checkpoint_data` type annotation updated to match `fetch_flink_job_checkpoints` return type

`tests/test_flink_tools.py`

• `TestFormatFlinkJobsTable`: 6 tests covering job table rendering, job limit, verbose mode, state colors, checkpoints/restarts, missing dashboard URL

[Copilot]

Pull request overview

Final cleanup for FLINK-5911 (part 4/4): completes the refactor so status.py is primarily orchestration while Flink-specific logic (formatting + async fetch helpers) lives in flink_tools.py.

Changes:

• Made Flink job detail/checkpoint fetch helpers public (fetch_flink_job_details, fetch_flink_job_checkpoints) and adjusted call sites accordingly.
• Simplified format_flink_jobs_table() signature (removed unused job_ids, made checkpoint_data optional with a None default).
• Added focused unit tests for format_flink_jobs_table() rendering behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
paasta_tools/flink_tools.py	Publicizes fetch helpers; simplifies jobs table formatter signature; minor refactor in should_job_info_be_shown.
paasta_tools/cli/cmds/status.py	Consolidates Flink API calls behind flink_tools.* and simplifies orchestration/variable initialization.
tests/test_flink_tools.py	Adds a new test class covering job table formatting behaviors and edge cases.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

collect_flink_job_details() accepts a jobs list and returns it in the details dict, but this call always passes [] even though jobs has just been fetched. Consider passing the jobs variable here (or, if jobs are intentionally unused in the details struct, remove the jobs parameter from collect_flink_job_details to avoid misleading call sites).

[nemacysts]

less code in status.py is always nice :D