Adding helm upgrade command instead of helm install#200
Open
dmytro-kyrychenko wants to merge 2 commits intoYangCatalog:developfrom
Open
Adding helm upgrade command instead of helm install#200dmytro-kyrychenko wants to merge 2 commits intoYangCatalog:developfrom
dmytro-kyrychenko wants to merge 2 commits intoYangCatalog:developfrom
Conversation
…amp to deployments
dmytro-kyrychenko
requested review from
SlavomirMazurPantheon and
richardzilincikPantheon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timestamps are added, because helm doesn't checks checksum of docker images (only tag names) and we always use 'latest' tag for our images. With our current approach to tags 'helm upgrade' would not work without this workaround. However, if we want to upgrade 1 docker image at a time, while deploying something, we should consider changing tags in deployments or alternatively, search for other workaround that will explicitly check checksums of docker image.