This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Merged
Conversation
because 1.9.16 breaks smithy builds.
Contributor
|
+1 |
Last updated on Tuesday, March 03 04:18 PM CST |
|
+1 |
Contributor
|
@charliekump-wf ready to merge and bugfix patch release |
Contributor
Contributor
|
QA Resource Approval: +10
Merging into master. |
charliekump-wf
added a commit
that referenced
this pull request
Mar 3, 2015
CP-436 Pin Phantomjs to 1.9.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because 1.9.16 breaks smithy builds.
Currently wGulp is getting phantomjs through
karma-phantomjs-launcher. If we specify an exact version here, npm should use it to fulfillkarma-phantomjs-launcher's dependency as long as it matches the semver range (which it does).Testing
git clean -xdfnpm installNotice karma-phantomjs-launcher did not specify its own version of phantomjs. phantomjs@1.9.16 is no where to be found 👍
FYA:
@trentgrover-wf
@evanweible-wf