Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

CP-436 Pin Phantomjs to 1.9.15#135

Merged
charliekump-wf merged 1 commit intomasterfrom
fixPhantomJs
Mar 3, 2015
Merged

CP-436 Pin Phantomjs to 1.9.15#135
charliekump-wf merged 1 commit intomasterfrom
fixPhantomJs

Conversation

@maxwellpeterson-wf
Copy link
Member

Because 1.9.16 breaks smithy builds.

Currently wGulp is getting phantomjs through karma-phantomjs-launcher. If we specify an exact version here, npm should use it to fulfill karma-phantomjs-launcher's dependency as long as it matches the semver range (which it does).

Testing

  • Checked out this branch
  • git clean -xdf
  • npm install
  • Inspect output:
karma-phantomjs-launcher@0.1.4 node_modules/karma-phantomjs-launcher
...
phantomjs@1.9.15 node_modules/phantomjs
├── which@1.0.9
├── progress@1.1.8
├── kew@0.4.0
├── request-progress@0.3.1 (throttleit@0.0.2)
├── fs-extra@0.16.4 (jsonfile@2.0.0, rimraf@2.2.8, graceful-fs@3.0.5)
├── adm-zip@0.4.4
├── npmconf@2.0.9 (uid-number@0.0.5, osenv@0.1.0, ini@1.3.3, inherits@2.0.1, once@1.3.1, config-chain@1.1.8, nopt@3.0.1, semver@4.3.1)
└── request@2.42.0 (caseless@0.6.0, json-stringify-safe@5.0.0, aws-sign2@0.5.0, forever-agent@0.5.2, stringstream@0.0.4, oauth-sign@0.4.0, tunnel-agent@0.4.0, qs@1.2.2, node-uuid@1.4.2, mime-types@1.0.2, form-data@0.1.4, http-signature@0.10.1, tough-cookie@0.12.1, hawk@1.1.1, bl@0.9.4)

Notice karma-phantomjs-launcher did not specify its own version of phantomjs. phantomjs@1.9.16 is no where to be found 👍

FYA:
@trentgrover-wf
@evanweible-wf

because 1.9.16 breaks smithy builds.
@trentgrover-wf
Copy link
Contributor

+1

@rmconsole-wf
Copy link

    When this pull is merged I will use the following information:
    Version: wGulp 0.7.7
    Release Ticket: CP-342

Last updated on Tuesday, March 03 04:18 PM CST

@evanweible-wf
Copy link

+1

@trentgrover-wf
Copy link
Contributor

@charliekump-wf ready to merge and bugfix patch release

@charliekump-wf charliekump-wf changed the title Pin Phantomjs to 1.9.15 CP-436 Pin Phantomjs to 1.9.15 Mar 3, 2015
@charliekump-wf
Copy link
Contributor

@rmconsole-wf

@charliekump-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • Smithy passes.
  • Unit test created/updated
  • All unit tests pass

Merging into master.

charliekump-wf added a commit that referenced this pull request Mar 3, 2015
CP-436 Pin Phantomjs to 1.9.15
@charliekump-wf charliekump-wf merged commit 41f8136 into master Mar 3, 2015
@charliekump-wf charliekump-wf deleted the fixPhantomJs branch March 3, 2015 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants