Skip to content

[i18n] ja translations developer architecture Service Workers and Scopes#3431

Merged
fellyph merged 1 commit intoWordPress:trunkfrom
shimotmk:docs/i18n-ja-translations-developer-architecture-12-and-13
Apr 1, 2026
Merged

[i18n] ja translations developer architecture Service Workers and Scopes#3431
fellyph merged 1 commit intoWordPress:trunkfrom
shimotmk:docs/i18n-ja-translations-developer-architecture-12-and-13

Conversation

@shimotmk
Copy link
Copy Markdown
Contributor

Motivation for the change, related issues

Part of #2202

Add Japanese translations to Service Workers and Scopes

@shimotmk shimotmk requested review from a team, adamziel and Copilot March 25, 2026 02:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Japanese (ja) translations for the “Service Workers” and “Scopes” architecture docs as part of #2202.

Changes:

  • Added ja translation page for browser service workers, including code examples.
  • Added ja translation page for browser scopes, including worker initialization example.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
packages/docs/site/i18n/ja/docusaurus-plugin-content-docs/current/developers/23-architecture/13-browser-scopes.md Adds Japanese translation for the “Scopes” doc page.
packages/docs/site/i18n/ja/docusaurus-plugin-content-docs/current/developers/23-architecture/12-browser-service-workers.md Adds Japanese translation for the “Service Workers” doc page (with setup examples).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +91 to +93
"default", // PHPインスタンススコープ
"/sw.js", // 有効な Service Worker 実装を指定する必要があります。
"1" // スクリプトの再読み込みに使用されるService Workerのバージョン。
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc references two different service worker script paths: "/sw.js" in the registration example vs /service-worker.js in the text and filename label. This is confusing for readers and makes the setup steps ambiguous. Use a single consistent filename/path across the snippet and the surrounding explanation (either update the registration example to "/service-worker.js" or change the later references to /sw.js).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@fellyph fellyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimotmk!

@fellyph fellyph merged commit 78eaacc into WordPress:trunk Apr 1, 2026
47 checks passed
@shimotmk shimotmk deleted the docs/i18n-ja-translations-developer-architecture-12-and-13 branch April 1, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants