Remove trailing semicolon from example URL for loading playground with network access#1520
Merged
bgrgicak merged 1 commit intoWordPress:trunkfrom Jun 18, 2024
oskosk:patch-1
Merged
Remove trailing semicolon from example URL for loading playground with network access#1520bgrgicak merged 1 commit intoWordPress:trunkfrom oskosk:patch-1
bgrgicak merged 1 commit intoWordPress:trunkfrom
oskosk:patch-1
Conversation
…h network access It can be confusing if one attempts to copypasting that line for reloading the page as the value for `networking` ends up being `yes;`
bgrgicak
pushed a commit
that referenced
this pull request
Jun 20, 2024
…h network access (#1520) It can be confusing if one attempts to copypaste that line for reloading the page as the value for `networking` ends up being `yes;` ### After  ### Before <img width="1003" alt="image" src="https://github.com/WordPress/wordpress-playground/assets/746152/adf04f97-b7df-4ead-a2e1-52629f9b54fb"> ## Motivation for the change, related issues While showcasing Playground during WCEU, I found myself failing to install plugins after copy-pasting the proposed URL until I realized I was copying an unintended semicolon. ## Implementation details ## Testing Instructions (or ideally a Blueprint)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be confusing if one attempts to copypaste that line for reloading the page as the value for
networkingends up beingyes;After
Before
Motivation for the change, related issues
While showcasing Playground during WCEU, I found myself failing to install plugins after copy-pasting the proposed URL until I realized I was copying an unintended semicolon.
Implementation details
Testing Instructions (or ideally a Blueprint)