Passing int term term_exists parent param not respected#9092
Passing int term term_exists parent param not respected#9092vijendrajat wants to merge 2 commits intoWordPress:trunkfrom
Conversation
This PR fixes a bug in the term_exists function where the parent_term wasn’t being considered correctly. When a term ID (as an integer) was passed along with a parent term ID, the function would only check if the term ID existed and completely ignore whether it was under the specified parent. Updated the term_exists logic to include the parent in the query when both a term ID and parent term ID are provided. Added a condition to ensure that the parent is checked as part of the query when relevant.
|
Hi @vijendrajat! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 participant
This PR fixes a bug in the
term_existsfunction where theparent_termwasn’t being considered correctly. When a term ID (as an integer) was passed along with a parent term ID, the function would only check if the term ID existed and completely ignore whether it was under the specified parent.term_existslogic to include the parent in the query when both a term ID and parent term ID are provided.Trac ticket: https://core.trac.wordpress.org/ticket/55358
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.