Twenty Fifteen - update aria attributes on primary menu#8290
Twenty Fifteen - update aria attributes on primary menu#8290bschneidewind wants to merge 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
On the 2015 theme, when a child menu item is the currently active page the menu will be expanded by default - however the aria-expanded attribute remains false and attribute toggles the incorrect value when opened/closed.
The aria-controls attribute is currently not present.
The PR resolves both these items.
Trac ticket: https://core.trac.wordpress.org/ticket/62936
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.