Allow default duotone styles in themes that don't disable them.#5817
Closed
tellthemachines wants to merge 5 commits intoWordPress:trunkfrom
Closed
Allow default duotone styles in themes that don't disable them.#5817tellthemachines wants to merge 5 commits intoWordPress:trunkfrom
tellthemachines wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tellthemachines
commented
Jan 4, 2024
| */ | ||
| public function test_core_default_settings_are_loaded_for_themes_without_theme_json() { | ||
| switch_theme( 'default' ); | ||
| remove_theme_support( 'editor-gradient-presets' ); |
Contributor
Author
There was a problem hiding this comment.
I have added this here as a temp fix for the same problem encountered in #5816. If that patch is committed first, we should be able to safely remove this.
andrewserong
approved these changes
Jan 4, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing nicely for me and now allows the default Duotone styles in classic themes such as TT1 👍
| Before | After |
|---|---|
 |
 |
tellthemachines
force-pushed
the
fix/default-duotone-output
branch
from
a87d4ed to
5b1cdca
Compare
Contributor
Author
|
Thanks for the review! Committed in r57260. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60136
Syncs changes from WordPress/gutenberg#57191.
Added a unit test.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.