Add background-repeat to safe_style_css#5814
Closed
andrewserong wants to merge 3 commits intoWordPress:trunkfrom
Closed
Add background-repeat to safe_style_css#5814andrewserong wants to merge 3 commits intoWordPress:trunkfrom
andrewserong wants to merge 3 commits intoWordPress:trunkfrom
Conversation
ramonjd
approved these changes
Dec 22, 2023
Member
ramonjd
left a comment
There was a problem hiding this comment.
I ran the tests.
The tests passed.
👍🏻
Contributor
Author
|
Thanks for giving this a quick look! I forgot to add the ticket number to the test that uses this data provider. Added in 5fc84d2 |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
approved these changes
Dec 22, 2023
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Member
|
Thanks for the PR! Merged in r57228. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
background-repeatproperty tosafe_style_cssto support the missing background repeat property.This is a prerequisite for adding in a background-repeat toggle to the background image support feature, which has landed in Gutenberg in: WordPress/gutenberg#57005
Note: that PR includes other PHP changes that will be backported separately, so that this PR can just focus on the proposed change to
kses.phpand its tests.To test, ensure the tests pass, or if you're using the Docker environment for wordpress-develop, run the following locally: npm run test:php /var/www/tests/phpunit/tests/kses.php
Trac ticket: https://core.trac.wordpress.org/ticket/60132
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.