Global styles revisions: add route for single styles revisions#5622
Closed
ramonjd wants to merge 4 commits intoWordPress:trunkfrom
Closed
Global styles revisions: add route for single styles revisions#5622ramonjd wants to merge 4 commits intoWordPress:trunkfrom
ramonjd wants to merge 4 commits intoWordPress:trunkfrom
Conversation
577884b to
c1b0b81
Compare
This was referenced Jan 18, 2024
Contributor
|
@ramonjd Is it possible to add a unit test for this? |
Contributor
I see unit tests in this PR.
What am I missing? |
Contributor
That my brain is confused with too many tabs maybe :P You're right there are unit tests. |
Member
Author
|
Thanks for double checking, folks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For awareness, some of these changes can be merged with this PR:
What?
Syncing Gutenberg PR:
Adding route for single global styles revisions:
/wp/v2/global-styles/${ parentId }/revisions/${ revisionsId }Why?
To make global styles revisions compatible with the proposed Core Data revisions API, that is, so that we can fetch single revisions via
getRevision().Trac ticket: https://core.trac.wordpress.org/ticket/59810
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.