r56991 Test 2: Fixes static property handling. #5561
Closed
hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
Closed
r56991 Test 2: Fixes static property handling. #5561hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
hellofromtonya wants to merge 3 commits intoWordPress:trunkfrom
Conversation
hellofromtonya
commented
Oct 24, 2023
costdev
reviewed
Oct 24, 2023
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
costdev
approved these changes
Oct 24, 2023
Contributor
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Thanks @hellofromtonya! Looks good to me!
hellofromtonya
force-pushed
the
r56991/fix-test-using-reflectionproperty
branch
from
4b78254 to
3d18830
Compare
Contributor
Author
|
Committed into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@costdev found the test in r56991 did not properly handle the private static property:
WP_Block🤦♀️This PR fixes both of these issues.
It also addresses handling issues.
It also adds an inline comment to explain why an instance of
WP_Duotoneis needed. IMO having an instance is confusing.Why?
WP_Duotoneis a static class by design (as noted above), meaning it's not intended to be an object. But as of PHP 8.3, not passing an instance toReflectionProperty::setValue()is deprecated. Therefore, an instance is needed to run in all Core supported PHP versions.Trac ticket: https://core.trac.wordpress.org/ticket/59694
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.