Update dev container config - Dev container fixes#4050
Update dev container config - Dev container fixes#4050samruddhikhandale wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
Hi, first of all really cool that you made Wordpress compatible with GitHub CodeSpaces! I also tested it outside of this repository and it works in my repository too. I could see a small issue both here and on my machine, where this step seems to be executed too early: Wordpress can't be installed via the CLI on my system because some files are still missing. If I build in a "sleep" it works. Otherwise I have to run the CLI command manually. |
Interesting, I have tested this in a Codespace and locally on my machine, however, this issue never reproduced for me. @devfle Can you try switching the |
changed it and removed the sleep and still getting the following wp cli Error: "This does not seem to be a WordPress installation." Because some WP Files are missing. |
|
Just gave this a go both in Codespaces and locally and it works beautifully! Going to commit so folks have it for WordCamp Asia's contributor day this weekend :) @devfle Might help if you're able to share more of the creation log, I'm not getting that either so it's a bit hard to figure out which direction to go without more information since we're not able to reproduce yet. |
|
Committed in https://core.trac.wordpress.org/changeset/55353 / 5a87725 |
Following up from #4031
Updates dev container config for local development with Dev Containers.