Change color for added menu items and update hover icon (in Customizer)

[zerosonesfun]

This change makes the added menu item in Customizer WCAG compliant while leaving subtle effects to let the user know that they already added the menu item, but also, if they want they can add it again. This decision was made because it's the least amount of CSS changes while still making sense.

The same dark gray color used initially for menu item labels in Customizer is reused because a color change is not needed. The user will already see the checkmark icon indicating that the item was successfully added. Since you can add the same menu item multiple times (which should stay as-is in case a user has a complex repetitive menu or some reason I'm not thinking of), I also changed the on hover icon to the plus icon. This way, after adding, the user sees the check mark (☑️ great, it added!). If they want to re-add, instead of seeing the initial blue hover color, they see the dark gray but also the plus icon. This combination says, "you already added this, but add it again if you want."

Other solutions would add more lines of CSS or require more changes. I'm a fan of fixing the WCAG issue with minimal changes.

Trac ticket: https://core.trac.wordpress.org/ticket/64013

---

Current:

New, after adding:

New, after adding and on hover:

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wilcosky, joedolson, sabernhardt, showravhasan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[showravhasan1]

Test Report ✅

Tested on a local WordPress 6.9 installation with Twenty Twenty-One theme.

Bug Confirmed

• Current color: #8c8f94
• Contrast ratio: 3.24:1 (fails WCAG AA 4.5:1 minimum)
• Added menu items in Customizer are hard to read

Steps to Reproduce

1. Appearance → Customize → Menus
2. Open "Primary Menu"
3. Click "Add Items" → Pages
4. Add any page to the menu
5. Observe: The added item text is low contrast gray

Verdict

LGTM 👍 The fix to darken the text color correctly addresses the accessibility issue.

Also left a comment on the Trac ticket: https://core.trac.wordpress.org/ticket/64013

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61511
GitHub commit: c22a748

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.