Skip to content

Move class-two-factor-core.php login styles from inline to enqueued stylesheet #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgestephanis merged 4 commits into from
Mar 2, 2026
Merged

Move class-two-factor-core.php login styles from inline to enqueued stylesheet #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fba5603
add core css to user-edit.css file
masteradhoc Feb 22, 2026
611dcbb
enqueue css and remove style from file
masteradhoc Feb 22, 2026
cf91318
Fix lint
masteradhoc Feb 22, 2026
762e058
Merge branch 'master' into style-core-file
masteradhoc Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions class-two-factor-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,8 @@ public static function login_html( $user, $login_nonce, $redirect_to, $error_msg
// Disable the language switcher.
add_filter( 'login_display_language_dropdown', '__return_false' );

wp_enqueue_style( 'user-edit-2fa', plugins_url( 'user-edit.css', __FILE__ ), array(), TWO_FACTOR_VERSION );

login_header();

if ( ! empty( $error_msg ) ) {
Expand Down Expand Up @@ -1100,33 +1102,6 @@ public static function login_html( $user, $login_nonce, $redirect_to, $error_msg
</div>
<?php endif; ?>

<style>
/* @todo: migrate to an external stylesheet. */
.backup-methods-wrap {
margin-top: 16px;
padding: 0 24px;
}
.backup-methods-wrap a {
text-decoration: none;
}
.backup-methods-wrap ul {
list-style-position: inside;
}
/* Prevent Jetpack from hiding our controls, see https://github.com/Automattic/jetpack/issues/3747 */
.jetpack-sso-form-display #loginform > p,
.jetpack-sso-form-display #loginform > div {
display: block;
}
#login form p.two-factor-prompt {
margin-bottom: 1em;
}
.input.authcode {
letter-spacing: .3em;
}
.input.authcode::placeholder {
opacity: 0.5;
}
</style>
<script>
(function() {
// Enforce numeric-only input for numeric inputmode elements.
Expand Down
31 changes: 31 additions & 0 deletions user-edit.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,37 @@
margin: 0 0.15rem;
}

.backup-methods-wrap {
margin-top: 16px;
padding: 0 24px;
}

.backup-methods-wrap a {
text-decoration: none;
}

.backup-methods-wrap ul {
list-style-position: inside;
}
Comment on lines +21 to +32
Copy link
Copy Markdown
Collaborator Author

@masteradhoc masteradhoc Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.backup-methods-wrap {
margin-top: 16px;
padding: 0 24px;
}
.backup-methods-wrap a {
text-decoration: none;
}
.backup-methods-wrap ul {
list-style-position: inside;
}
#login .backup-methods-wrap {
margin-top: 16px;
padding: 0 24px;
}
#login .backup-methods-wrap a {
text-decoration: none;
}
#login .backup-methods-wrap ul {
list-style-position: inside;
}


/* Prevent Jetpack from hiding our controls, see https://github.com/Automattic/jetpack/issues/3747 */
.jetpack-sso-form-display #loginform > p,
.jetpack-sso-form-display #loginform > div {
display: block;
}

#login form p.two-factor-prompt {
margin-bottom: 1em;
}

.input.authcode {
letter-spacing: 0.3em;
}

.input.authcode::placeholder {
opacity: 0.5;
}
Comment on lines +44 to +50
Copy link
Copy Markdown
Collaborator Author

@masteradhoc masteradhoc Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.input.authcode {
letter-spacing: 0.3em;
}
.input.authcode::placeholder {
opacity: 0.5;
}
#loginform .input.authcode {
letter-spacing: 0.3em;
}
#loginform .input.authcode::placeholder {
opacity: 0.5;
}


.two-factor-backup-codes-wrapper > :not(:last-child) {
margin-bottom: 1em;
}
Expand Down