This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Remove unnecessary font weight rule font-weight rule from index and home templates#290
Merged
Remove unnecessary font weight rule font-weight rule from index and home templates#290
Conversation
kjellr
commented
Dec 10, 2021
| <div class="wp-block-query alignwide"><!-- wp:post-template {"align":"wide"} --> | ||
| <!-- wp:group {"layout":{"inherit":true}} --> | ||
| <div class="wp-block-group"><!-- wp:post-title {"isLink":true,"align":"wide","style":{"typography":{"fontStyle":"normal","fontWeight":"300"}},"fontSize":"huge"} /--> | ||
| <div class="wp-block-group"><!-- wp:post-title {"isLink":true,"align":"wide","fontSize":"huge"} /--> |
Collaborator
Author
There was a problem hiding this comment.
For consistency, I made the same change in the pattern for this query layout.
jffng
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary font style + weight declarations from the
home.htmlandindex.htmltemplates. These are unnecessary, because the same font weight rule is defined in theme.json already:twentytwentytwo/theme.json
Line 232 in e9f4980
... and
normalis already the default value for this text anyway.Removing these from the templates provides more flexibility in customization from child themes, and through
theme.json. For example, the "Swiss" variation in this PR tries to make all post titles bold. Before that rule was overridden here didn't work, but with this PR it works fine:There should be no appearance change by default, since these deleted rules exist already.