Update: remove default attributes from template part blocks in templates#435
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @alexandreb@bsa-web.fr. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you, @alexandrebuffet. I'll go ahead and review it shortly. Can you please connect your GitHub account to your WordPress.org account to receive props for your contributions? Please see the tutorials on Linking your GitHub and w.org profiles. |
|
Thank you @juanfra! Oops I pushed with a work account like a newbie. Is there a way to change the commit author from here or I need to create a new PR? |
juanfra
left a comment
There was a problem hiding this comment.
Thank you, it looks that there are a few places where the changes are missing:
- photo-blog-archive-template.php
- photo-blog-home-template.php
- photo-blog-page-template.php
- photo-blog-search-results-template.php
- photo-blog-single-post-template.php
- post-with-left-aligned-content.php
- text-only-blog-archive-template.php
- text-only-blog-home-template.php
- text-only-blog-search-template.php
- text-only-blog-single-post-template.php
- news-blog-archive-template.php
- news-blog-home-template.php
- news-blog-search-results-template.php
- news-blog-single-post-with-sidebar-template.php
- news-blog-with-featured-posts-grid-template.php
- news-blog-with-sidebar-template.php
Can you please update those as well?
No problem, it looks like it's fixed now: |
|
Thank you @juanfra! Oh yes, I forgot the patterns! I've updated the PR. |
Description
Removes "area" and "tagName" default attributes from template part blocks in templates for better consistency as discussed in issue #325.