Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Update: remove default attributes from template part blocks in templates#435

Merged
juanfra merged 2 commits intoWordPress:trunkfrom
alexandrebuffet:update/remove-default-template-part-attributes
Sep 26, 2024
Merged

Update: remove default attributes from template part blocks in templates#435
juanfra merged 2 commits intoWordPress:trunkfrom
alexandrebuffet:update/remove-default-template-part-attributes

Conversation

@alexandrebuffet
Copy link
Copy Markdown
Contributor

Description

Removes "area" and "tagName" default attributes from template part blocks in templates for better consistency as discussed in issue #325.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 26, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alexandreb@bsa-web.fr.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: alexandreb@bsa-web.fr.

Co-authored-by: alexandrebuffet <alexandrebuffet@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra
Copy link
Copy Markdown
Member

juanfra commented Sep 26, 2024

Thank you, @alexandrebuffet. I'll go ahead and review it shortly. Can you please connect your GitHub account to your WordPress.org account to receive props for your contributions?

Please see the tutorials on Linking your GitHub and w.org profiles.

@alexandrebuffet
Copy link
Copy Markdown
Contributor Author

Thank you @juanfra! Oops I pushed with a work account like a newbie. Is there a way to change the commit author from here or I need to create a new PR?

Copy link
Copy Markdown
Member

@juanfra juanfra left a comment

@juanfra
Copy link
Copy Markdown
Member

juanfra commented Sep 26, 2024

Thank you @juanfra! Oops I pushed with a work account like a newbie. Is there a way to change the commit author from here or I need to create a new PR?

No problem, it looks like it's fixed now: Co-authored-by: alexandrebuffet <alexandrebuffet@git.wordpress.org>

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 26, 2024
@alexandrebuffet
Copy link
Copy Markdown
Contributor Author

Thank you @juanfra! Oh yes, I forgot the patterns! I've updated the PR.

Copy link
Copy Markdown
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much 🚀

@juanfra juanfra merged commit 690b889 into WordPress:trunk Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Make the inclusion of the header and footer template parts consistent

2 participants