Skip Command Palette e2e tests on older WP versions#404
Merged
Conversation
ockham
commented
Apr 9, 2026
| await page.keyboard.press( 'ControlOrMeta+k' ); | ||
|
|
||
| const input = page.getByRole( 'combobox', { | ||
| name: 'Search commands and settings', |
Contributor
Author
There was a problem hiding this comment.
This used to be Type a command or search in WP 6.3, so a label-agnostic way of locating the input field was needed.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
deleted the
update/skip-command-palette-e2e-tests-in-older-wp-versions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests are currently run against WP 6.2 upon commit to
trunk. Command Palette tests are failing, as the Command Palette was only introduced in WP 6.3. We thus need to skip those tests on older WP versions.Additionally, this PR makes the test more resilient against minor copy changes across versions that would previously cause tests to fail.
Use of AI Tools
Claude Code was used to select the command palette input field in a label-agnostic way that would work across different WP versions.