Server-Timing: Leverage core template enhancement output buffer in WordPress 6.9+#2389
Draft
sarthak-19 wants to merge 1 commit intoWordPress:trunkfrom
Draft
Server-Timing: Leverage core template enhancement output buffer in WordPress 6.9+#2389sarthak-19 wants to merge 1 commit intoWordPress:trunkfrom
sarthak-19 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…p_before_include_template action when available in WP 6.9+
Member
|
If implement this after #2354 then we won't need to add the back-compat code to be compatible with <6.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Issue : #2225
Summary
When WordPress 6.9+ is available (Core-43258, r60936), Performance Lab no longer needs to open its own output buffer for Server-Timing metrics. Instead, it leverages the new core infrastructure:
wp_template_enhancement_output_bufferfilter instead of starting a customob_start()attemplate_redirect.wp_before_include_templateaction instead of misusing thetemplate_includefilter.On older WordPress versions, the existing behavior is preserved as a fallback.