Restore original template registration tests alongside activation variants#77068
Merged
Restore original template registration tests alongside activation variants#77068
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
force-pushed
the
fix/template-registration-tests
branch
from
0c2afff to
bdf03fd
Compare
…t into separate file The template registration tests were modified in #73252 to go through the template activation flow (Duplicate → Activate → Trash). This broke the tests when running without the Gutenberg plugin or without the active_templates experiment enabled. This restores the original pre-template-activation tests in template-registration.spec.js and copies the current trunk version (unchanged) to template-registration-activation.spec.js. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
force-pushed
the
fix/template-registration-tests
branch
from
bdf03fd to
796a5da
Compare
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b73f77d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24072036173
|
…on tests Port the toBeLessThanOrEqual and URL search param assertion from the activation variant, which improves test stability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
added
the
Backport to WP 7.0 Beta/RC
Member
Author
|
Let's backport just so the 7.0 branch is tested too. |
ellatrix
added
the
[Type] Automated Testing
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Apr 7, 2026
…iants (#77068) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: f2a2aa6 |
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
…iants (#77068) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Restores the original template registration e2e tests that work without the
active_templatesexperiment, while keeping the template activation variants in a separate file.Why?
When template activation was moved to an experiment in #73252 (originally introduced in #67125), the original template registration tests were not restored.
How?
template-registration.spec.js— restored to its state before Allow template duplication + concept of active templates #67125, with thesearchForTemplatestability fix from Allow template duplication + concept of active templates #67125 ported overtemplate-registration-activation.spec.js— exact copy of the current trunktemplate-registration.spec.js(unchanged)Test plan
active_templatesexperiment