Storybook: Fix "Default" cursor option in theming toolbar#77037
Merged
Conversation
mirka
added
[Type] Developer Documentation
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 44ab5c4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23954647935
|
aduth
approved these changes
Apr 6, 2026
Member
There was a problem hiding this comment.
I suppose this likely worked before but regressed when we changed the default in #76762 ? In any case, it makes sense that this setting should set the value explicitly 👍
I wondered if the same would be true of the other "Default" settings here (COLOR_OPTIONS, DENSITY_OPTIONS), but I suppose there's a conflation of "default" as-in "what happens if you don't specify a value" and "default" as in cursor: default, where in the latter case we may default to the non-cursor: default styling 😅 🤯 (#71316) That being said, I think explicit 'default' density can work, and maybe we'd want the color option to be explicitly "Light".
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
Right, it's a bit confusing here but I don't think there's an easy way out, fundamentally 😅 Except we can probably improve the theming toolbar UI so there's a difference between |
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug in the Storybook theming toolbar where the "Default" cursor option wasn't working properly.
How?
Sets the Default option’s
idto'default'so the global and decorator passcursor={{ control: 'default' }}as intended.Testing Instructions
npm run storybook:devand go to a Design System component story.var(--wpds-cursor-control)should use the normal arrow cursor.Use of AI Tools
Composer 2